From 69f61757c46fd072437e2e7112c615900e7bdeff Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Mon, 17 Jun 2019 09:47:02 -0400 Subject: [PATCH] Added API support for ladder visibility control. --- .../orderman/orders/algo/AlgoWrapperOrder.cpp | 16 +++++++++++++--- src/lib/orderman/orders/algo/AlgoWrapperOrder.h | 3 ++- src/lib/orderman/orders/algo/IAlgoServices.h | 7 +++++++ src/server/sparkd/cmds/QuickTest.cpp | 1 + 4 files changed, 23 insertions(+), 4 deletions(-) diff --git a/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp b/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp index 950c619a3..c0e83266b 100644 --- a/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp +++ b/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp @@ -47,6 +47,7 @@ struct AlgoWrapperOrder::PImpl { OrderDefinition definition; const api::Security *security; OrderState const &state() const { return _state; } + OrderState &state() { return _state; } Map book_subs; Map children; @@ -167,7 +168,7 @@ void AlgoWrapperOrder::on_init_recovered( terminate(ORDER_STATUS_ERROR, "System restarted with active algo order"); return; - // Terminal states + // Terminal states case ORDER_STATUS_ERROR: case ORDER_STATUS_REJECTED_BY_SPARK: case ORDER_STATUS_COMPLETED: @@ -175,7 +176,7 @@ void AlgoWrapperOrder::on_init_recovered( terminate(rec.state().status(), rec.state().last_msg()); break; - // It should not be possible to reach these + // It should not be possible to reach these case ORDER_STATUS_DISCONNECTED: case ORDER_STATUS_INACTIVE: case OrderStatus_INT_MIN_SENTINEL_DO_NOT_USE_: @@ -298,7 +299,7 @@ orderman::OrderOpResult AlgoWrapperOrder::on_cancel() { cancel(); break; case IAlgoOrder::OnCancelResponse::IGNORE: - LOG(OrderMan,Info,"Algo order with key {} ignored cancel request", + LOG(OrderMan, Info, "Algo order with key {} ignored cancel request", key().value()); break; } @@ -501,6 +502,15 @@ void AlgoWrapperOrder::update_fill_state(Quantity q, Price p) { } } +void AlgoWrapperOrder::set_ladder_visibility(bool is_visible) { + if (!is_working()) + return; + + ReportStateGuard _(*this); + me->state().set_display_status(is_visible ? OrderState::VISIBLE + : OrderState::HIDDEN); +} + void AlgoWrapperOrder::cancel(std::string const &msg) { if (!is_working()) return; diff --git a/src/lib/orderman/orders/algo/AlgoWrapperOrder.h b/src/lib/orderman/orders/algo/AlgoWrapperOrder.h index ef36b638a..f11a84a23 100644 --- a/src/lib/orderman/orders/algo/AlgoWrapperOrder.h +++ b/src/lib/orderman/orders/algo/AlgoWrapperOrder.h @@ -58,7 +58,8 @@ class AlgoWrapperOrder : public Order, void terminate_error(std::string const &msg) override; void complete() override; void update_fill_state(Quantity total_fills, Price last_price) override; - + void set_ladder_visibility (bool is_visibile) override; + // Private struct ReportStateGuard; struct ChildRecord; diff --git a/src/lib/orderman/orders/algo/IAlgoServices.h b/src/lib/orderman/orders/algo/IAlgoServices.h index 9d61c9282..4d9cd2f2f 100644 --- a/src/lib/orderman/orders/algo/IAlgoServices.h +++ b/src/lib/orderman/orders/algo/IAlgoServices.h @@ -80,6 +80,13 @@ class IAlgoServices : public IBeforeLaunchAlgoServices { // active children. virtual void complete() = 0; + // -------------------------------------------------------------- + // Algo State Update + // -------------------------------------------------------------- + + // Set wheter this algo instance should be displayed in the Spark UI ladder + virtual void set_ladder_visibility(bool is_visible) = 0; + // Update this algos's filled quantity and last price virtual void update_fill_state(Quantity total_fills, Price last_price) = 0; }; diff --git a/src/server/sparkd/cmds/QuickTest.cpp b/src/server/sparkd/cmds/QuickTest.cpp index ebc012dbe..f6f86be5a 100644 --- a/src/server/sparkd/cmds/QuickTest.cpp +++ b/src/server/sparkd/cmds/QuickTest.cpp @@ -46,6 +46,7 @@ struct Proxy : public IAlgoServices { void terminate_error(std::string const &) {} void complete() {} void update_fill_state(Quantity , Price ) {} + void set_ladder_visibility(bool) {} }; int QuickTest::execute(std::vector const &) {