From 69e338c1ca14c4426abdb300ae96c0bd7fe00698 Mon Sep 17 00:00:00 2001 From: John Colvin Date: Fri, 13 Jun 2025 21:26:36 +0000 Subject: [PATCH] fix: Use lock_guard instead of lock/unlock calls I just noticed it was technically possible for the "work thread" (in py plugin manager) to be started twice, due to improper lock/unlock calls. --- src/lib_python_interop/python_interop/plugin_manager.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib_python_interop/python_interop/plugin_manager.cpp b/src/lib_python_interop/python_interop/plugin_manager.cpp index 4b8e54553..9ff7e0e11 100644 --- a/src/lib_python_interop/python_interop/plugin_manager.cpp +++ b/src/lib_python_interop/python_interop/plugin_manager.cpp @@ -88,13 +88,11 @@ struct __attribute__((visibility("hidden"))) PluginManager_Impl { PluginManager_SessionData *session_data; void start_work_thread() { - mx.lock(); + std::lock_guard lock{mx}; if (work_thread) { - mx.unlock(); return; } keep_going = true; - mx.unlock(); work_thread.emplace([&]() { PluginManager_SessionData sd; mx.lock();