diff --git a/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs b/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs index e1c33486b..aac89a1c2 100644 --- a/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs +++ b/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs @@ -11,6 +11,8 @@ using mbts.ui.utility; using System; using System.Collections.Generic; using System.Collections.ObjectModel; +using System.Collections.Specialized; +using System.ComponentModel; using System.Linq; using System.Reactive.Linq; using System.Windows; @@ -19,10 +21,11 @@ using System.Windows.Media; using TextUtils = mbts.ui.utility.text.TextUtils; namespace mbts.spark { - class LadderSettingsVM : ViewModelBase, IWindowSettingsVM, ITemplateSelectorKey, IDisposable { + class LadderSettingsVM : DisposableViewModelBase, IWindowSettingsVM, IValueFactory, IObservable, ITemplateSelectorKey { readonly Property _badge_style; readonly Property _alternate_order_size; readonly DelegateProperty _row_height; + readonly DeferrableActionWrapper _update; LadderSettings.NetChangeTerms _price_format; Func _get_order_entry_panel_width, _get_zoom_factor; LadderSettings _current; @@ -79,10 +82,25 @@ namespace mbts.spark { _ask.font_size_changed += on_font_size_changed; _last.font_size_changed += on_font_size_changed; _piq.font_size_changed += on_font_size_changed; - + // update + _update = new DeferrableActionWrapper(() => result_changed?.Invoke()); + foreach (var c in _observable_components) + c.PropertyChanged += on_prop_changed; + favorite_algos_vm.items.CollectionChanged += on_favorite_algo_items_CollectionChanged; + _dispose = Disposable.Create(() => { + favorite_algos_vm.items.CollectionChanged -= on_favorite_algo_items_CollectionChanged; + favorite_algos_vm.Dispose(); + foreach (var c in _observable_components) + c.PropertyChanged -= on_prop_changed; + }); + // local methods void on_font_size_changed(double oldval, double newval) => _row_height.refresh(); + void on_prop_changed(object sender, PropertyChangedEventArgs e) => _update.execute(); + void on_favorite_algo_items_CollectionChanged(object sender, NotifyCollectionChangedEventArgs e) => _update.execute(); } + public event Action result_changed; + private void _badge_style_Changed(LadderSettings.BadgeStyle oldval, LadderSettings.BadgeStyle newval) { if (newval == LadderSettings.BadgeStyle.Alternate && _orders.font_size == 10) { _orders.font_size = 7; @@ -172,49 +190,95 @@ namespace mbts.spark { public string key => GridSettingsTemplateKeys.Ladder; + IEnumerable _observable_components { + get { + // columns + yield return _orders; + yield return _bid; + yield return _price; + yield return _ask; + yield return _last; + yield return _piq; + yield return _volume; + yield return _volume.general; + // market break lines + yield return _bid_mkt_line; + yield return _ask_mkt_line; + yield return _mid_mkt_line; + yield return _session_low_mkt_line; + yield return _session_high_mkt_line; + yield return _session_range_fill; + // left panel + yield return _zoom_slider_visbility; + yield return _day_visibility; + yield return _high_visibility; + yield return _low_visibility; + yield return _open_visibility; + yield return _settle_visibility; + yield return _volume_visibility; + yield return _account_visibility; + yield return _tif_visibility; + yield return _order_type_visibility; + yield return _account_position_visibility; + yield return _day_position_visibility; + yield return _size_preset_visibility; + yield return _auto_clear_visibility; + yield return _clear_visibility; + yield return _cancel_buys_visibility; + yield return _cancel_sells_visibility; + yield return _cancel_all_visibility; + // other + yield return size_display; + yield return favorite_algos_vm; + yield return this; + } + } + public void load(LadderSettings settings) { - _current = settings; - badge_style = settings.badge_style; - alternate_order_size = settings.alternate_order_size; - favorite_algos_vm.load_from(settings.favorite_algos); - size_display.load_from(settings.size_display); - size_presets.SetItems(settings.calculator_buttons.empty_if_null().Select(s => _create_size_preset_vm((uint)s))); - _orders.assign_from(_current.orders_column); - _bid.assign_from(_current.bid_column); - _ask.assign_from(_current.ask_column); - _price.assign_from(_current.price_column); - _volume.assign_from(_current.volume_column); - _last.assign_from(_current.last_column); - _piq.assign_from(_current.piq_column); - _bid_mkt_line.assign_from(_current.bid_break_line); - _ask_mkt_line.assign_from(_current.ask_break_line); - _mid_mkt_line.assign_from(_current.mid_break_line); - _session_low_mkt_line.assign_from(_current.session_low_line); - _session_high_mkt_line.assign_from(_current.session_high_line); - _session_range_fill.assign_from(_current.session_range_fill); - _zoom_slider_visbility.show = settings.zoom_slider_visible; - _day_visibility.show = settings.day_visible; - _high_visibility.show = settings.high_visible; - _low_visibility.show = settings.low_visible; - _open_visibility.show = settings.open_visible; - _settle_visibility.show = settings.settle_visible; - _volume_visibility.show = settings.volume_visible; - _account_visibility.show = settings.account_visible; - _tif_visibility.show = settings.tif_visible; - _order_type_visibility.show = settings.order_type_visible; - _account_position_visibility.show = settings.account_position_visible; - _day_position_visibility.show = settings.day_position_visible; - _size_preset_visibility.show = settings.size_presets_visible; - _clear_visibility.show = settings.clear_visible; - _auto_clear_visibility.show = settings.auto_clear_visible; - _cancel_buys_visibility.show = settings.cancel_buys_visible; - _cancel_sells_visibility.show = settings.cancel_sells_visible; - _cancel_all_visibility.show = settings.cancel_all_visible; - price_format = settings.net_change; - // do not read the order entry panel width here from settings - // because it could have changed from the UI - // there might be a better way of doing this, like how - // does the widths of the ladder grid column pull this off? + using (_update.defer_execution()) { + _current = settings; + badge_style = settings.badge_style; + alternate_order_size = settings.alternate_order_size; + favorite_algos_vm.load_from(settings.favorite_algos); + size_display.load_from(settings.size_display); + size_presets.SetItems(settings.calculator_buttons.empty_if_null().Select(s => _create_size_preset_vm((uint)s))); + _orders.assign_from(_current.orders_column); + _bid.assign_from(_current.bid_column); + _ask.assign_from(_current.ask_column); + _price.assign_from(_current.price_column); + _volume.assign_from(_current.volume_column); + _last.assign_from(_current.last_column); + _piq.assign_from(_current.piq_column); + _bid_mkt_line.assign_from(_current.bid_break_line); + _ask_mkt_line.assign_from(_current.ask_break_line); + _mid_mkt_line.assign_from(_current.mid_break_line); + _session_low_mkt_line.assign_from(_current.session_low_line); + _session_high_mkt_line.assign_from(_current.session_high_line); + _session_range_fill.assign_from(_current.session_range_fill); + _zoom_slider_visbility.show = settings.zoom_slider_visible; + _day_visibility.show = settings.day_visible; + _high_visibility.show = settings.high_visible; + _low_visibility.show = settings.low_visible; + _open_visibility.show = settings.open_visible; + _settle_visibility.show = settings.settle_visible; + _volume_visibility.show = settings.volume_visible; + _account_visibility.show = settings.account_visible; + _tif_visibility.show = settings.tif_visible; + _order_type_visibility.show = settings.order_type_visible; + _account_position_visibility.show = settings.account_position_visible; + _day_position_visibility.show = settings.day_position_visible; + _size_preset_visibility.show = settings.size_presets_visible; + _clear_visibility.show = settings.clear_visible; + _auto_clear_visibility.show = settings.auto_clear_visible; + _cancel_buys_visibility.show = settings.cancel_buys_visible; + _cancel_sells_visibility.show = settings.cancel_sells_visible; + _cancel_all_visibility.show = settings.cancel_all_visible; + price_format = settings.net_change; + // do not read the order entry panel width here from settings + // because it could have changed from the UI + // there might be a better way of doing this, like how + // does the widths of the ladder grid column pull this off? + } } public LadderSettings get_result() { @@ -262,7 +326,13 @@ namespace mbts.spark { return clone; } - public void Dispose() => favorite_algos_vm.Dispose(); + public IDisposable defer_updates() => _update.defer_execution(); + + IDisposable IObservable.Subscribe(IObserver observer) { + result_changed += notify; + return Disposable.Create(() => result_changed -= notify); + void notify() => observer.OnNext(get_result()); + } IMutableValueWrapperVM _create_size_preset_vm() => _create_size_preset_vm(0); IMutableValueWrapperVM _create_size_preset_vm(uint init) { @@ -408,7 +478,6 @@ namespace mbts.spark { public string name { get; } public bool show { get => _show.Value; set => _show.Value = value; } - } public class VolumeColumnVM : ViewModelBase { @@ -590,4 +659,4 @@ namespace mbts.spark { } } } -} \ No newline at end of file +}