From 5b520ba241f6d32051d1f8b09f68e96a0f4d935c Mon Sep 17 00:00:00 2001 From: John Colvin Date: Sun, 23 Feb 2025 19:05:32 +0000 Subject: [PATCH] cleanup: Get rid of custom fmt::formatter for security proto Security proto objects are large, so we shouldn't pass them by value to the log system. The custom formatter's presence makes this easy to do by accident. --- src/lib/domain_model/Security.h | 3 --- src/lib/md/MDConsumer.cpp | 3 ++- src/lib/md/SecurityCache.cpp | 4 +++- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/domain_model/Security.h b/src/lib/domain_model/Security.h index 53f160aeb..afd9b434c 100644 --- a/src/lib/domain_model/Security.h +++ b/src/lib/domain_model/Security.h @@ -1,6 +1,5 @@ #pragma once -#include "lib/core/FMT_IMPL.h" #include "lib/domain_model/PutOrCall.h" #include "lib/domain_model/Security.pb.h" #include "lib/domain_model/SecurityType.h" @@ -436,5 +435,3 @@ inline bool is_spread_of_strips(const bts::api::Security &sec) { } } // namespace bts::securities - -FMT_IMPL(bts::api::Security, s, "{}", bts::securities::descriptor(s)); diff --git a/src/lib/md/MDConsumer.cpp b/src/lib/md/MDConsumer.cpp index 67eb15903..6e3aaf4bf 100644 --- a/src/lib/md/MDConsumer.cpp +++ b/src/lib/md/MDConsumer.cpp @@ -435,7 +435,8 @@ class SyntheticConsumerInst { void add_security(const api::Security &sec) { Mutex::scoped_lock lock(_workmutex); if (_data.find(sec.id()) == _data.end()) { - LOG(md, Info, "MDConsumer::add_security. {}", sec); + LOG(md, Info, "MDConsumer::add_security. {}", + bts::securities::descriptor(sec)); auto ptr = to_strategy(make_shared(sec)); vector vec; vec.push_back(ptr); diff --git a/src/lib/md/SecurityCache.cpp b/src/lib/md/SecurityCache.cpp index bb5288d30..11845ccb2 100644 --- a/src/lib/md/SecurityCache.cpp +++ b/src/lib/md/SecurityCache.cpp @@ -295,7 +295,9 @@ bool SecurityCache::add_live_security(const SecurityPtr &security) { return is_new_sec; }); if (is_new_sec) { - INFO_FN("add_live_security", "new security: {}", *security); + INFO_FN( + "add_live_security", "new security: {}", + bts::securities::descriptor(*security)); } return is_new_sec; }