From 45f02391d1f28913e7e63888e40a4dfd0cecf58c Mon Sep 17 00:00:00 2001 From: John Colvin Date: Mon, 3 Jun 2024 17:48:13 +0000 Subject: [PATCH] cleanup: Remove sparkd login creds from PubSubServerConfig It only needs a Sparkd url to download logging config. TBH, we can probably get rid of that too, and simply read the local spark.conf. --- .../PubSubServer/PubSubServerConfig.cs | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/DataStreamSuite/PubSubServer/PubSubServerConfig.cs b/src/DataStreamSuite/PubSubServer/PubSubServerConfig.cs index d3f9b3e25..31482328a 100644 --- a/src/DataStreamSuite/PubSubServer/PubSubServerConfig.cs +++ b/src/DataStreamSuite/PubSubServer/PubSubServerConfig.cs @@ -10,20 +10,6 @@ using System.Text.Json; using System.Text.Json.Serialization; public class PubSubServerConfig { - /// - /// The login user for sparkd - /// - [JsonPropertyName("user")] - [Option("user", HelpText = "The sparkd login user")] - public string? User { get; set; } - - /// - /// The login password for sparkd - /// - [JsonPropertyName("password")] - [Option("pass", HelpText = "The sparkd login password")] - public string? Password { get; set; } - /// /// The config server url for sparkd /// @@ -47,7 +33,6 @@ public class PubSubServerConfig { public static PubSubServerConfig Default() => new() { - User = "bts", Sparkd = "http://localhost:8000/config", SimpleEchoServer = false, PubSub = PubSubConfig.Default(), @@ -55,8 +40,6 @@ public class PubSubServerConfig { }; public void MergeWith(PubSubServerConfig other) { - User ??= other.User; - Password ??= other.Password; Sparkd ??= other.Sparkd; SimpleEchoServer ??= other.SimpleEchoServer; PubSub ??= other.PubSub;