From 4228dcab95edc19f3ab481c886575093db226526 Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Tue, 13 Aug 2019 20:03:58 -0400 Subject: [PATCH] Added unnormalized_day position data to PositionUnit --- src/lib/api/services/PositionService.proto | 4 ++++ src/server/sparkd/position/PositionMap.cpp | 8 ++++++++ 2 files changed, 12 insertions(+) diff --git a/src/lib/api/services/PositionService.proto b/src/lib/api/services/PositionService.proto index 538be9ce6..3e8e992bf 100644 --- a/src/lib/api/services/PositionService.proto +++ b/src/lib/api/services/PositionService.proto @@ -31,6 +31,10 @@ message PositionUnit{ double day_short_avg_price = 100; PositionEntry sod = 110; PositionEntry day = 120; + // this is the position without the spread legs + // being incorporated into the outright position + // (for spreads, day == unnormalized_day) + PositionEntry unnormalized_day = 125; PositionEntry local = 130; PositionEntry admin_sod = 140; PositionEntry admin_day = 150; diff --git a/src/server/sparkd/position/PositionMap.cpp b/src/server/sparkd/position/PositionMap.cpp index 414a69e9e..9d2b58eb3 100644 --- a/src/server/sparkd/position/PositionMap.cpp +++ b/src/server/sparkd/position/PositionMap.cpp @@ -59,6 +59,13 @@ const PositionUnit& PositionMap::on_fill (const Fill& f, f.last_shares(), f.fill_key(), is_add); + if (f.fill_kind() == Fill::FILL_KIND_STANDARD) + PositionUtilities::apply_fill(*(pu.mutable_unnormalized_day()), + f.side(), + f.last_price(), + f.last_shares(), + f.fill_key(), + is_add); break; } PositionUtilities::backwards_compat(pu); @@ -190,6 +197,7 @@ void PositionMap::_fill_account (PositionUnit& u){ void PositionMap::_zero_out_pos_unit (bts::api::position::PositionUnit& pu){ _zero_out_pos_entry(*pu.mutable_day()); + _zero_out_pos_entry(*pu.mutable_unnormalized_day()); _zero_out_pos_entry(*pu.mutable_sod()); _zero_out_pos_entry(*pu.mutable_local()); _zero_out_pos_entry(*pu.mutable_admin_day());