diff --git a/src/lib/md/MDConsumerHandle.cpp b/src/lib/md/MDConsumerHandle.cpp index 4f6ea5f9a..54d0f45c0 100644 --- a/src/lib/md/MDConsumerHandle.cpp +++ b/src/lib/md/MDConsumerHandle.cpp @@ -2,6 +2,7 @@ #include "MDConsumerHandle.h" #include "MBOProcessor.h" #include "lib/domain_model/Security.h" +#include "lib/os/os.h" #include #define never bts_assert(false) @@ -12,13 +13,13 @@ namespace bts { namespace md { MDConsumerHandle::MDConsumerHandle() { - memset(this, 0, sizeof(MDConsumerHandle)); + os::memset(this, 0, sizeof(MDConsumerHandle)); _type = HANDLETYPE_VOID; static_assert(sizeof(MDConsumerHandle) <= 40, ""); } MDConsumerHandle::MDConsumerHandle( const std::shared_ptr &def) { - memset(this, 0, sizeof(MDConsumerHandle)); + os::memset(this, 0, sizeof(MDConsumerHandle)); synthetic.def = def; _type = HANDLETYPE_SYNTHETIC; for (size_t x = 0; x < def->legs.size(); ++x) { @@ -29,7 +30,7 @@ MDConsumerHandle::MDConsumerHandle( } MDConsumerHandle::MDConsumerHandle(const MDConsumerHandle &other) { - memset(this, 0, sizeof(MDConsumerHandle)); + os::memset(this, 0, sizeof(MDConsumerHandle)); _type = HANDLETYPE_VOID; *this = other; } diff --git a/src/lib/md/MDProducer.cpp b/src/lib/md/MDProducer.cpp index 3b61e4405..97fd372f0 100644 --- a/src/lib/md/MDProducer.cpp +++ b/src/lib/md/MDProducer.cpp @@ -7,6 +7,7 @@ #include "SecurityIDRecorder.h" #include "Shm/MDStructure.h" #include "lib/md/Diag/ShmDumper.h" +#include "lib/os/os.h" #include "lib/utils/SharedList.h" #include "lib/utils/WaitFreeQueue.h" #include @@ -70,7 +71,7 @@ class MDProducerImpl { ColdEntry *c_entry = new (_cold.add(ColdEntry::fixed_size() + security.size)) ColdEntry(security.size); - memcpy(&c_entry->security, &security, security.size); + os::memcpy(&c_entry->security, &security, security.size); smapper.apply(c_entry->security); MDProducerHandle handle( diff --git a/src/lib/md/test/Co2TestInstrument.cpp b/src/lib/md/test/Co2TestInstrument.cpp index ba3533c11..da9ef23f6 100644 --- a/src/lib/md/test/Co2TestInstrument.cpp +++ b/src/lib/md/test/Co2TestInstrument.cpp @@ -1,6 +1,7 @@ #define _DISABLE_EXTENDED_ALIGNED_STORAGE #include "Co2TestInstrument.h" #include "lib/md/MemorySegmentUtils.h" +#include "lib/os/os.h" namespace bts { namespace md { @@ -22,7 +23,7 @@ Co2TestInstrument::Co2TestInstrument( new uint8_t[ColdEntry::fixed_size() + fsec.size], std::default_delete()); _cold = new (_cold_buffer.get()) ColdEntry(fsec.size); - memcpy(&_cold->security, &fsec, fsec.size); + os::memcpy(&_cold->security, &fsec, fsec.size); }); } @@ -41,7 +42,7 @@ Co2TestInstrument::Co2TestInstrument( new uint8_t[ColdEntry::fixed_size() + fsec.size], std::default_delete()); _cold = new (_cold_buffer.get()) ColdEntry(fsec.size); - memcpy(&_cold->security, &fsec, fsec.size); + os::memcpy(&_cold->security, &fsec, fsec.size); }); } diff --git a/src/lib/md/vendor/OnixsUtils.cpp b/src/lib/md/vendor/OnixsUtils.cpp index 4295fa3bc..04d90d38a 100644 --- a/src/lib/md/vendor/OnixsUtils.cpp +++ b/src/lib/md/vendor/OnixsUtils.cpp @@ -3,6 +3,8 @@ #include "lib/config/config.h" #include "lib/config/protos/market_data.pb.h" #include "lib/logging/logging.h" +#include +#include namespace bts { namespace md { diff --git a/src/lib/mercury/actors/ContentSubscription.h b/src/lib/mercury/actors/ContentSubscription.h index f1dfffacf..9aa7a5167 100644 --- a/src/lib/mercury/actors/ContentSubscription.h +++ b/src/lib/mercury/actors/ContentSubscription.h @@ -6,6 +6,7 @@ #include #include #include +#include #include namespace bts { @@ -27,7 +28,7 @@ struct NoKey { // (late join) or reentrancy (unsub while handling an update). template class ContentSubscription { public: - using Key = decltype((*((KE *)nullptr))(*((EV *)nullptr))); + using Key = std::invoke_result_t; using CB = std::function; struct SubID { SubID() : k(), sid(0) {} diff --git a/src/lib/mercury/synopsis/MergeByKey.h b/src/lib/mercury/synopsis/MergeByKey.h index 7603c536c..69b572561 100644 --- a/src/lib/mercury/synopsis/MergeByKey.h +++ b/src/lib/mercury/synopsis/MergeByKey.h @@ -2,6 +2,7 @@ #include "lib/mercury/synopsis/ISynopsisBuilder.h" #include +#include #include namespace bts { @@ -11,7 +12,7 @@ namespace mercury { // published for each key template class MergeByKey : public ISynopsisBuilder { public: - using RefConstKey = decltype(((EV *)nullptr)->key()); + using RefConstKey = std::invoke_result_t; using ConstKey = typename std::remove_reference::type; using Key = typename std::remove_const::type; diff --git a/src/lib/orderman/ilink3/IL3Parser.cpp b/src/lib/orderman/ilink3/IL3Parser.cpp index c5532ecc5..d435f0f05 100644 --- a/src/lib/orderman/ilink3/IL3Parser.cpp +++ b/src/lib/orderman/ilink3/IL3Parser.cpp @@ -10,6 +10,7 @@ #include "lib/orderman/orderman_utils/CancelReject.h" #include "lib/orderman/orderman_utils/fix_order_codec.h" #include "lib/orderman/orderman_utils/orderman_common.h" +#include "lib/os/os.h" namespace bts { namespace orderman { @@ -334,7 +335,7 @@ void IL3Parser::set_account( if (details.partyDetailRole() == iLinkBinary::PartyDetailRole::CustomerAccount) { const char *p_account = details.partyDetailID(); - strncpy( + os::strncpy( most_recent_account.value().data(), p_account, most_recent_account.value().size()); break; diff --git a/src/lib/orderman/ilink3/IL3Reactor.cpp b/src/lib/orderman/ilink3/IL3Reactor.cpp index 2e037a3af..8b0df2ff6 100644 --- a/src/lib/orderman/ilink3/IL3Reactor.cpp +++ b/src/lib/orderman/ilink3/IL3Reactor.cpp @@ -198,7 +198,17 @@ constexpr bool has_error(int events) { void IL3Reactor::do_work() { std::array ev_list; + #ifndef __clang__ + #pragma GCC diagnostic push + #pragma GCC diagnostic ignored "-Wmaybe-uninitialized" + #endif + // A bug in gcc causes bogus errors related to 'unitialized' variables + // (particularly when accessing array::size). + // https://cplusplus.com/forum/beginner/22044/ auto ready = epoll_wait(me->epoll_fd, ev_list.data(), ev_list.size(), 0); + #ifndef __clang__ + #pragma GCC diagnostic pop + #endif if (ready == -1) { if (errno == EINTR) return; diff --git a/src/lib/orderman/ilink3/SessionStore.cpp b/src/lib/orderman/ilink3/SessionStore.cpp index c79bb8a61..ac3eee808 100644 --- a/src/lib/orderman/ilink3/SessionStore.cpp +++ b/src/lib/orderman/ilink3/SessionStore.cpp @@ -9,6 +9,7 @@ #include "lib/utils/thread_manager.h" #include +#include #include #include #include diff --git a/src/lib/orderman/orderman_utils/fix_order_codec.h b/src/lib/orderman/orderman_utils/fix_order_codec.h index fcccd75fe..d4828719c 100644 --- a/src/lib/orderman/orderman_utils/fix_order_codec.h +++ b/src/lib/orderman/orderman_utils/fix_order_codec.h @@ -7,6 +7,7 @@ #include "lib/jetfix/codec/i32_toa.h" #include "lib/utils/base62.h" #include "lib/utils/bts_assert.h" +#include "lib/os/os.h" #include "orderman_common.h" namespace bts { @@ -99,7 +100,7 @@ inline void encode_corid(const char *channel, uint32_t sn, std::array &out) { memset(&out[0], ' ', out.size()); auto ch_sz = std::min(strlen(channel), (size_t)5); - strncpy(&out[0], channel, ch_sz); + os::strncpy(&out[0], channel, ch_sz); out[ch_sz] = ':'; auto sz_written = u32_toa(sn, &out[ch_sz + 1]); out[ch_sz + 1 + sz_written] = ' '; diff --git a/src/lib/orderman/orders/algo/algo_orders/tests/AlgoTestDriver.cpp b/src/lib/orderman/orders/algo/algo_orders/tests/AlgoTestDriver.cpp index 58e5e3283..388e3a04a 100644 --- a/src/lib/orderman/orders/algo/algo_orders/tests/AlgoTestDriver.cpp +++ b/src/lib/orderman/orders/algo/algo_orders/tests/AlgoTestDriver.cpp @@ -362,7 +362,7 @@ OrderKey AlgoTestDriverBase::order_key() const { return me->order_key; } OrderKey AlgoTestDriverBase::parent_order_key() const { return me->parent_key; } const api::Security * AlgoTestDriverBase::lookup_security(SecurityKey key) const { - auto s = get_some_securities(); + const auto &s = get_some_securities(); auto iter = s.find(key); if (iter != s.end()) { return &iter->second; diff --git a/src/lib/os/os.h b/src/lib/os/os.h index 26a8364dc..42c335816 100644 --- a/src/lib/os/os.h +++ b/src/lib/os/os.h @@ -3,6 +3,7 @@ #include "lib/utils/bts_export.h" #include +#include #include #include #include @@ -90,6 +91,27 @@ inline double nan() { return std::numeric_limits::quiet_NaN(); } BTS_EXPORT float fnan(); BTS_EXPORT bool is_finite(double d); int cache_size_l3_bytes(); + +template +void memcpy(T* dest, const T* src, std::size_t n); + +template +void memset(T* s, int c, std::size_t n); + +////////////////////////////////////////////////// +// Definition +////////////////////////////////////////////////// + +template +void memcpy(T* dest, const T* src, std::size_t n) { + ::memcpy((void*)dest, (void*)src, n); + +} +template +void memset(T* s, int c, std::size_t n) { + ::memset((void*)s, c, n); +} + } // namespace os } // namespace bts diff --git a/src/lib/tracing/PerfLog.cpp b/src/lib/tracing/PerfLog.cpp index 18c7ca7a2..fba95aa83 100644 --- a/src/lib/tracing/PerfLog.cpp +++ b/src/lib/tracing/PerfLog.cpp @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/src/lib/utils/SharedList.h b/src/lib/utils/SharedList.h index 6d5b011cd..b6f002221 100644 --- a/src/lib/utils/SharedList.h +++ b/src/lib/utils/SharedList.h @@ -13,6 +13,7 @@ #include #include +#include #include #include #include diff --git a/src/lib/utils/crypto/CryptoInit.cpp b/src/lib/utils/crypto/CryptoInit.cpp index bf158f7ef..6aada042c 100644 --- a/src/lib/utils/crypto/CryptoInit.cpp +++ b/src/lib/utils/crypto/CryptoInit.cpp @@ -1,6 +1,7 @@ #ifndef _WIN32 #include "CryptoInit.h" +#include #include #include diff --git a/src/lib/utils/sftp.cpp b/src/lib/utils/sftp.cpp index 6ee6952c6..5d8817bea 100644 --- a/src/lib/utils/sftp.cpp +++ b/src/lib/utils/sftp.cpp @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include diff --git a/src/server/sparkd/cmds/spartan/back_testing/matcher/FillDepot.h b/src/server/sparkd/cmds/spartan/back_testing/matcher/FillDepot.h index ef3630515..b5058a901 100644 --- a/src/server/sparkd/cmds/spartan/back_testing/matcher/FillDepot.h +++ b/src/server/sparkd/cmds/spartan/back_testing/matcher/FillDepot.h @@ -34,7 +34,7 @@ class FillNode { MDP3Fill buy_aggressor; MDP3Fill sell_aggressor; - OrderKey curr_aggressor; + OrderKey curr_aggressor{0}; std::vector direct_passive, implied_passive; std::uint32_t _fill_count = 0; }; diff --git a/src/server/sparkd/cmds/spartan/feed_handler/detail/FeedHandler_Recovery.cpp b/src/server/sparkd/cmds/spartan/feed_handler/detail/FeedHandler_Recovery.cpp index 8ad1fe76c..321b4e4f4 100644 --- a/src/server/sparkd/cmds/spartan/feed_handler/detail/FeedHandler_Recovery.cpp +++ b/src/server/sparkd/cmds/spartan/feed_handler/detail/FeedHandler_Recovery.cpp @@ -230,7 +230,7 @@ FeedHandler_Recovery::try_build_snapshot_and_reset() { // ready to go auto result = rt_handler.move_all_securities_and_reset(); reset(); - return std::move(result); + return result; } // Instrument feed ------------------------------------------- diff --git a/src/server/sparkd/cmds/spartan/system/Reactor.cpp b/src/server/sparkd/cmds/spartan/system/Reactor.cpp index 5a17fdf9e..b0df4a0e7 100644 --- a/src/server/sparkd/cmds/spartan/system/Reactor.cpp +++ b/src/server/sparkd/cmds/spartan/system/Reactor.cpp @@ -212,7 +212,7 @@ static constexpr bool has_error(int events) { } void Reactor::do_work() { - std::array ev_list; + std::array ev_list{}; auto ready = epoll_wait(me->epoll_fd, ev_list.data(), ev_list.size(), 0); if (ready == -1) { if (errno == EINTR) diff --git a/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp b/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp index f0e50daf1..d6017c26b 100644 --- a/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp +++ b/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp @@ -41,6 +41,7 @@ #include #include #include +#include #include #include #include diff --git a/src/server/sparkd/position/PositionServicePNLHelper.cpp b/src/server/sparkd/position/PositionServicePNLHelper.cpp index 109073201..7974b2d2e 100644 --- a/src/server/sparkd/position/PositionServicePNLHelper.cpp +++ b/src/server/sparkd/position/PositionServicePNLHelper.cpp @@ -16,6 +16,7 @@ #include #include #include +#include #include #include