From 23c8b60ea30cf447ac61de4e7a033812d2a2627d Mon Sep 17 00:00:00 2001 From: Kevin Darby Date: Mon, 21 May 2018 13:57:36 -0400 Subject: [PATCH] spreader post hedge should be < thresh not > --- docker/linux | 2 +- .../orders/spreader_orders/spreader/SpreaderUtils.h | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docker/linux b/docker/linux index 6037d094b..bc896f18d 160000 --- a/docker/linux +++ b/docker/linux @@ -1 +1 @@ -Subproject commit 6037d094b7ce931f526394644be5e35629cdb3a0 +Subproject commit bc896f18dc1431377fa533cb14276c14583c8bda diff --git a/src/server/sparkd/orderman/orders/spreader_orders/spreader/SpreaderUtils.h b/src/server/sparkd/orderman/orders/spreader_orders/spreader/SpreaderUtils.h index 7f079ba87..f06d569b4 100644 --- a/src/server/sparkd/orderman/orders/spreader_orders/spreader/SpreaderUtils.h +++ b/src/server/sparkd/orderman/orders/spreader_orders/spreader/SpreaderUtils.h @@ -458,16 +458,16 @@ public: double& out_new_price) { const bts::spark::PostHedgeParams& post_hedge_params = leg_property_data.leg_params().post_hedge_params(); - if (post_hedge_params.has_price_based_cross()){ - if(post_hedge_price_based_forced_cross (curr_order_price, leg_property_data.trading_side(), book, leg_property_data.tick_size(), post_hedge_params.price_based_cross(), out_new_price)) - return true; - } if (post_hedge_params.has_opposite_market_volume_based_forced_cross()){ if (post_hedge_volume_based_forced_cross(curr_order_price, remaining_to_fill_qty, leg_property_data.trading_side(), book, leg_property_data.tick_size(), post_hedge_params.opposite_market_volume_based_forced_cross(), out_new_price)) return true; + } + if (post_hedge_params.has_price_based_cross()){ + if(post_hedge_price_based_forced_cross (curr_order_price, leg_property_data.trading_side(), book, leg_property_data.tick_size(), post_hedge_params.price_based_cross(), out_new_price)) + return true; } return false; } @@ -515,14 +515,14 @@ public: const md::PriceSize& opp_inside_price_size = book.side(api::Side::SIDE_SELL)[0]; // the price check is so that we dont repeatedly keep doing this // im the short period where our hedge order change has not effected the book - if (opp_inside_price_size.size() > threshold.value() && out_price < opp_inside_price_size.price()){ + if (opp_inside_price_size.size() < threshold.value() && out_price < opp_inside_price_size.price()){ out_new_price = opp_inside_price_size.price() + tick_size * volume_based_forced_cross.cross_ticks(); return true; } } else{ const md::PriceSize& opp_inside_price_size = book.side(api::Side::SIDE_BUY)[0]; - if (opp_inside_price_size.size() > threshold.value() && out_price > opp_inside_price_size.price()){ + if (opp_inside_price_size.size() < threshold.value() && out_price > opp_inside_price_size.price()){ out_new_price = opp_inside_price_size.price() - tick_size * volume_based_forced_cross.cross_ticks(); return true; }