From 1a192c81177bba6ec09b2804e8f59b779cbc0e43 Mon Sep 17 00:00:00 2001 From: John Colvin Date: Mon, 20 Jan 2025 11:21:00 -0500 Subject: [PATCH] feat: Add setting to show ladder prices in basis pts from mid --- .../Modules/Trading/Ladder/LadderSettings.cs | 6 +- .../Trading/Ladder/View/LadderGridHost.cs | 88 +++++++------- .../Trading/Ladder/View/LadderRender.cs | 108 ++++++++++-------- .../data/ticks/RegionalTickFactors.cs | 3 + 4 files changed, 117 insertions(+), 88 deletions(-) diff --git a/src/client/spark/Modules/Trading/Ladder/LadderSettings.cs b/src/client/spark/Modules/Trading/Ladder/LadderSettings.cs index ec381aa48..f0de2938d 100644 --- a/src/client/spark/Modules/Trading/Ladder/LadderSettings.cs +++ b/src/client/spark/Modules/Trading/Ladder/LadderSettings.cs @@ -727,7 +727,11 @@ namespace mbts.spark { [Description("Net Change Dollars")] Dollars, [Description("Net Change Ticks")] - Ticks + Ticks, + [Description("Basis Points")] + BasisPoints, + [Description("Net Basis Points")] + NetBasisPoints, } public enum PriceDisplayFormat { diff --git a/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs b/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs index c6faa8044..9f154c779 100644 --- a/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs +++ b/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs @@ -875,26 +875,7 @@ namespace mbts.spark { render_market_col(_bids, _bid_market_cell_background); break; case ColumnType.Price: - if (_settings.net_change != LadderSettings.NetChangeTerms.None) { - LadderRender.render_prices( - column.visual_tup.visual, - column.visual_tup.glyph_context, - _price_list, - _settings.row_height, - column.settings, - _spec, - _vm.md.settlement_price, - _settings.net_change == LadderSettings.NetChangeTerms.Ticks); - } else { - LadderRender.render_prices( - column.visual_tup.visual, - column.visual_tup.glyph_context, - _price_list, - _settings.row_height, - column.settings, - _spec, - _settings.price_display_format); - } + _refresh_prices(column); break; case ColumnType.Ask: render_market_col(_asks, _ask_market_cell_background); @@ -1104,6 +1085,23 @@ namespace mbts.spark { return Disposable.Create(() => _can_user_send_orders_changed -= o.OnNext); }); + LadderPriceList _create_price_list() { + if (_settings is not null) { + switch (_settings.net_change) { + case LadderSettings.NetChangeTerms.BasisPoints: + case LadderSettings.NetChangeTerms.NetBasisPoints: + return new() { + length = _initial_row_count, + regional_tick = new RegionalTickFactors(new user.settings.TickFactors(10000, 1)), + }; + } + } + return new() { + length = _initial_row_count, + regional_tick = _spec + }; + } + #region Timer.Tick, Refresh Methods void _tick() { if (_settings != null) { @@ -1113,10 +1111,7 @@ namespace mbts.spark { _mkt_break_lines.refresh(); if (_price_list is null) { Log.assert(_price_dirty); - _price_list = new LadderPriceList { - length = _initial_row_count, - regional_tick = _spec - }; + _price_list = _create_price_list(); var mid_tick = security.tickdiff(_mkt_break_lines.origin, 0) ?? 0; if (mid_tick > int.MaxValue) { Log.Ui.error( @@ -1163,8 +1158,17 @@ namespace mbts.spark { _refresh_bid_mkt_break(); if (_mkt_break_lines.ask_dirty) _refresh_ask_mkt_break(); - if (_mkt_break_lines.mid_dirty) + if (_mkt_break_lines.mid_dirty) { + switch (_settings.net_change) { + case LadderSettings.NetChangeTerms.BasisPoints: + case LadderSettings.NetChangeTerms.NetBasisPoints: + _refresh_prices(); + break; + default: + break; + } _refresh_mid_mkt_break(); + } _refresh_fair_value_lines(false); if (_mkt_break_lines.session_low_dirty) _refresh_session_low_line(); @@ -1190,25 +1194,27 @@ namespace mbts.spark { } } - void _refresh_prices() { + void _refresh_prices(Column column = null) { if (_settings is null) { return; } - - if (_settings.net_change != LadderSettings.NetChangeTerms.None) { - LadderRender.render_prices( - _price_vis_tup.visual, _price_vis_tup.glyph_context, - _price_list, _vm.md.settlement_price, - _settings.net_change == LadderSettings.NetChangeTerms.Ticks, - _settings.row_height, _settings.price_column, - _spec); - } else { - LadderRender.render_prices( - _price_vis_tup.visual, _price_vis_tup.glyph_context, - _price_list, _settings.row_height, - _settings.price_column, _spec, - _settings.price_display_format); - } + column ??= _price_column; + var ref_price = _settings.net_change switch { + LadderSettings.NetChangeTerms.BasisPoints or + LadderSettings.NetChangeTerms.NetBasisPoints or + LadderSettings.NetChangeTerms.Ticks => _get_mid_market_break(), + _ => 0.0 + }; + LadderRender.render_prices( + column.visual_tup.visual, + column.visual_tup.glyph_context, + _price_list, + ref_price, + _settings.net_change, + _settings.row_height, + column.settings, + _spec, + _settings.price_display_format); } void _refresh_all_visuals() { diff --git a/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs b/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs index 75c972478..e065f9e4d 100644 --- a/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs +++ b/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs @@ -102,17 +102,64 @@ namespace mbts.spark { settings.font_size, settings.width, row_height, HorizontalAlignment.Right, -4, VerticalAlignment.Center, row * row_height, true); - public static GlyphRun[] format_prices(IList prices, double reference_price, bool format_in_tick_terms, double row_height, LadderColumnSettings settings, GlyphContext glyph_context, RegionalTickFactors spec) { + public static GlyphRun[] format_prices( + IList prices, + double reference_price, + LadderSettings.NetChangeTerms terms, + double row_height, + LadderColumnSettings settings, + GlyphContext glyph_context, + RegionalTickFactors spec, + LadderSettings.PriceDisplayFormat price_display_format = LadderSettings.PriceDisplayFormat.Default + ) { var result = new GlyphRun[prices.Count]; + string basis_pts_fmt = terms switch { + LadderSettings.NetChangeTerms.BasisPoints or + LadderSettings.NetChangeTerms.NetBasisPoints => get_basis_pts_fmt(), + _ => null + }; Parallel.For(0, prices.Count, i => - result[i] = format_text(spec.format(prices[i] - reference_price, format_in_tick_terms), i, row_height, settings, glyph_context)); - return result; - } - public static GlyphRun[] format_prices(IList prices, double row_height, LadderColumnSettings settings, GlyphContext glyph_context, RegionalTickFactors spec, LadderSettings.PriceDisplayFormat price_display_format) { - var result = new GlyphRun[prices.Count]; - Parallel.For(0, prices.Count, i => - result[i] = format_text(spec.format(prices[i]), i, row_height, settings, glyph_context, price_display_format)); + result[i] = format_text(fmt(i), i, row_height, settings, glyph_context, price_display_format)); return result; + + string fmt(int i) { + switch (terms) { + case LadderSettings.NetChangeTerms.Dollars: + return prices[i].ToString("0.00"); + case LadderSettings.NetChangeTerms.BasisPoints: { + if (!reference_price.is_real_non_zero()) { + return spec.format(double.NaN); + } + var basis_pts = prices[i] * 10000.0 / reference_price; + return basis_pts.ToString(basis_pts_fmt); + } + case LadderSettings.NetChangeTerms.NetBasisPoints: { + if (!reference_price.is_real_non_zero()) { + return spec.format(double.NaN); + } + var net_basis_pts = prices[i] * 10000.0 / reference_price - 10000.0; + return net_basis_pts.ToString(basis_pts_fmt); + } + default: + return spec.format(prices[i]); + } + } + + string get_basis_pts_fmt() { + if (!reference_price.is_real_non_zero()) { + return "0.000"; + } + var tick_sz = spec.ticksize(reference_price); + var basis_pt = reference_price.abs() / 10000.0; + var precision_log10 = Math.Log10(tick_sz / basis_pt); + int n = 0; + if (precision_log10 < 0) { + n = (int)Math.Ceiling(-precision_log10); + } + return n < 1 + ? "0" + : "0." + new string('0', n); + } } public static void clear_prices(DrawingVisual price, int row_count, double row_height, LadderColumnSettings settings, GlyphContext glyph_context) { @@ -128,51 +175,20 @@ namespace mbts.spark { public static void render_prices( DrawingVisual price, GlyphContext glyph_context, - IList price_list, + IList dprices, double wrt_price, - bool format_in_tick_terms, + LadderSettings.NetChangeTerms terms, double row_height, LadderColumnSettings settings, - RegionalTickFactors tick) { - if (price_list.IsNullOrEmpty()) { + RegionalTickFactors tick, + LadderSettings.PriceDisplayFormat price_display_format = LadderSettings.PriceDisplayFormat.Default) { + if (dprices.IsNullOrEmpty()) { return; } - render_prices( - price, glyph_context, price_list, row_height, settings, tick, - wrt_price, format_in_tick_terms); - } - - public static void render_prices( - DrawingVisual price, - GlyphContext glyph_context, - IList dprices, - double row_height, - LadderColumnSettings settings, - RegionalTickFactors tick, - double wrt_price, - bool format_in_tick_terms) { var foreground = settings.foreground.rgb_brush(); //var background = new SolidColorBrush(settings.background.rgb_color()); - var fprices = format_prices(dprices, wrt_price, format_in_tick_terms, row_height, settings, glyph_context, tick); - using (var dc = price.RenderOpen()) - using (_draw_with_clip(dc, settings, row_height, dprices.Count)) { - //dc.DrawRectangle(background, null, new Rect(0, 0, settings.width, row_count * row_height)); - for (int x = 0; x < dprices.Count; ++x) - dc.DrawGlyphRun(foreground, fprices[x]); - } - } - - public static void render_prices( - DrawingVisual price, - GlyphContext glyph_context, - IList dprices, - double row_height, - LadderColumnSettings settings, - RegionalTickFactors tick, - LadderSettings.PriceDisplayFormat price_display_format) { - var foreground = settings.foreground.rgb_brush(); - //var background = new SolidColorBrush(settings.background.rgb_color()); - var fprices = format_prices(dprices, row_height, settings, glyph_context, tick, price_display_format); + var fprices = format_prices( + dprices, wrt_price, terms, row_height, settings, glyph_context, tick, price_display_format); using (var dc = price.RenderOpen()) using (_draw_with_clip(dc, settings, row_height, dprices.Count)) { //dc.DrawRectangle(background, null, new Rect(0, 0, settings.width, row_count * row_height)); diff --git a/src/client/spark_api/data/ticks/RegionalTickFactors.cs b/src/client/spark_api/data/ticks/RegionalTickFactors.cs index 47d440881..fd9f8993c 100644 --- a/src/client/spark_api/data/ticks/RegionalTickFactors.cs +++ b/src/client/spark_api/data/ticks/RegionalTickFactors.cs @@ -16,6 +16,9 @@ namespace mbts.user.settings { public RegionalTickFactors() : this(new TickFactors(), new TickFactors(), double.MinValue) { } + public RegionalTickFactors(TickFactors tick) + : this(tick, tick, double.PositiveInfinity) { } + public RegionalTickFactors(TickFactors low_tick, TickFactors high_tick, double low_tick_inclusive_end) { _low_tick = low_tick; _high_tick = high_tick;