From 146a136cd58e1416bf42a2be229e8d1a107ff84f Mon Sep 17 00:00:00 2001 From: John Colvin Date: Fri, 21 Jan 2022 21:20:20 -0500 Subject: [PATCH] Remove magic const '-1' in drag/drop is_sufficient_delta fn Not sure why this const was ever added in the first place, it appears to arbitrarily prevent drag/drop ops from starting, when the mouse is at coordinate (1,1) --- src/client/spark/view/DragDrop/DragDropHelper.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/client/spark/view/DragDrop/DragDropHelper.cs b/src/client/spark/view/DragDrop/DragDropHelper.cs index 7dc970b38..aad708e79 100644 --- a/src/client/spark/view/DragDrop/DragDropHelper.cs +++ b/src/client/spark/view/DragDrop/DragDropHelper.cs @@ -323,12 +323,12 @@ namespace mbts.ui { } #region Utility - public static bool is_sufficient_delta(Point origin, Point current) { - return - origin.X != -1 && origin.Y != -1 && - (Math.Abs(current.X - origin.X) >= SystemParameters.MinimumHorizontalDragDistance || - Math.Abs(current.Y - origin.Y) >= SystemParameters.MinimumVerticalDragDistance); - } + + public static bool is_sufficient_delta(Point start, Point stop) => + is_sufficient_delta(start, stop, SystemParameters.MinimumHorizontalDragDistance, SystemParameters.MinimumVerticalDragDistance); + + public static bool is_sufficient_delta(Point start, Point stop, double min_move_x, double min_move_y) => + Math.Abs(stop.X - start.X) >= min_move_x || Math.Abs(stop.Y - start.Y) >= min_move_y; private static void hide(FloatingWindow window, TabDocument document) { if (window.SingleChild) {