diff --git a/src/client/spark/Modules/Trading/PNL/Data/PNLData.cs b/src/client/spark/Modules/Trading/PNL/Data/PNLData.cs index bc151105f..590784e95 100644 --- a/src/client/spark/Modules/Trading/PNL/Data/PNLData.cs +++ b/src/client/spark/Modules/Trading/PNL/Data/PNLData.cs @@ -637,7 +637,7 @@ namespace bts.shell.pnl { public static (double default_cpp, double? override_cpp) pnl_cpp_tuple(this PNLUnitImmutable pnl_unit, SecurityImmutable security) { // TODO: actual impl double calced_pnl = PNLICEHelper.get_cpp(pnl_unit,security); - return (calced_pnl, /*pnl_unit.HasCppOverride ? pnl_unit.CppOverride.Value : */(double?)null); + return (calced_pnl, pnl_unit.HasCppOverride ? pnl_unit.CppOverride.Value : (double?)null); } } } diff --git a/src/server/sparkd/position/PositionServiceServer.cpp b/src/server/sparkd/position/PositionServiceServer.cpp index cd868c323..b42ae16d5 100644 --- a/src/server/sparkd/position/PositionServiceServer.cpp +++ b/src/server/sparkd/position/PositionServiceServer.cpp @@ -323,28 +323,28 @@ void PositionServiceServer::set_base_position( } void PositionServiceServer::update_security_parameters( - const SecurityParametersBatchOp&, + const SecurityParametersBatchOp& req, const api::Response&){ // TODO - // LOG(persist, Info, "PositionServiceServer::update_security_parameters bp count:{}", - // req.op_params_size()); - // for (const auto& p : req.op_params()){ - // std::string key_str = std::to_string(p.security_key()); - // auto db_p = me->security_params_store->retrieve_one(security_params_ns, key_str); - // auto found = db_p.first; - // if (!found) { - // me->security_params_store->insert(security_params_ns, - // key_str, - // utils::pb::to_string(p)); - // } - // else { - // me->security_params_store->insert(security_params_ns, - // key_str, - // utils::pb::to_string(p)); - // } - // } - // _load_security_params(); - // _compute_pnl_and_publish(); + LOG(persist, Info, "PositionServiceServer::update_security_parameters bp count:{}", + req.op_params_size()); + for (const auto& p : req.op_params()){ + std::string key_str = std::to_string(p.security_key()); + auto db_p = me->security_params_store->retrieve_one(security_params_ns, key_str); + auto found = db_p.first; + if (!found) { + me->security_params_store->insert(security_params_ns, + key_str, + utils::pb::to_string(p)); + } + else { + me->security_params_store->update(security_params_ns, + key_str, + utils::pb::to_string(p)); + } + } + _load_security_params(); + _compute_pnl_and_publish(); } ///////////////////////////////////////////////////////////////////////////////