From 02356cf97c7e2e2e264d892b3f3f45f34a29fad2 Mon Sep 17 00:00:00 2001 From: John Colvin Date: Fri, 28 Nov 2025 05:34:20 +0000 Subject: [PATCH] refactor: Make AtomicGate actually atomic (lockless) --- src/client/spark_core/Threading/AtomicGate.cs | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/client/spark_core/Threading/AtomicGate.cs b/src/client/spark_core/Threading/AtomicGate.cs index c3218c133..e2f2d22bc 100644 --- a/src/client/spark_core/Threading/AtomicGate.cs +++ b/src/client/spark_core/Threading/AtomicGate.cs @@ -16,7 +16,6 @@ public class AtomicGate { readonly string name; readonly int id = Interlocked.Increment(ref idCounter); - readonly object syncRoot = new(); int versionIn = 0; int versionOut = 0; @@ -55,13 +54,8 @@ public class AtomicGate { return res; bool Impl() { - lock (syncRoot) { - if (versionIn == versionOut) { - versionIn++; - return true; - } - } - return false; + int versOut = versionOut; + return Interlocked.CompareExchange(ref versionIn, versOut + 1, versOut) == versOut; } } @@ -140,10 +134,8 @@ public class AtomicGate { Task.Run(BeginTransaction); public void Exit() { - lock (syncRoot) { - Log.assert(versionIn == versionOut + 1); - versionOut = versionIn; - } + int versIn = Volatile.Read(ref versionIn); + Log.assert(Interlocked.CompareExchange(ref versionOut, versIn, versIn - 1) == versIn - 1); } void sleep(int sleepMillis, int? version = null) {