diff --git a/src/lib_python_interop/python_interop_plugins/bybit_md_provider.py b/src/lib_python_interop/python_interop_plugins/bybit_md_provider.py index 415e293fc..9e6a79228 100644 --- a/src/lib_python_interop/python_interop_plugins/bybit_md_provider.py +++ b/src/lib_python_interop/python_interop_plugins/bybit_md_provider.py @@ -74,13 +74,13 @@ def fetch_futures_specs(contracts: Iterable[str], use_testnet: bool = True) -> d continue tick_unit, tick_base = get_tick_factors(price_tick) - qty_tick_base = min(int(1 / qty_step), 1000000) if qty_step != 0 else 10000 + qty_tick_unit, qty_tick_base = get_tick_factors(qty_step) specs_dict[contract] = { "tick_unit": tick_unit, "tick_base": tick_base, "cash_per_point": 1, - "qty_tick_unit": 1, + "qty_tick_unit": qty_tick_unit, "qty_tick_base": qty_tick_base, "min_notional_value": float( lot_size.get("minNotionalValue", tick_unit / tick_base) diff --git a/src/lib_python_interop/python_interop_plugins/spark_core.py b/src/lib_python_interop/python_interop_plugins/spark_core.py index b045513c9..83bc87995 100644 --- a/src/lib_python_interop/python_interop_plugins/spark_core.py +++ b/src/lib_python_interop/python_interop_plugins/spark_core.py @@ -219,6 +219,9 @@ def get_tick_factors(tick_sz: float): """ if not (tick_sz > 0): raise ValueError(f"Invalid tick size {tick_sz}") + if tick_sz > 1: + # integer tick + return (tick_sz, 1) tick_denom = 1.0 / tick_sz match tick_denom: case 1: @@ -335,7 +338,7 @@ def get_quantity_info( max_price: Optional[float] = None, ): # Use 'not' checks to account for nans (for which every op evaluates to false) - if not (tick_unit > 0) or not (tick_base >= tick_unit): + if not (tick_unit > 0): raise ValueError(f"Invalid tick factors {tick_unit}/{tick_base}") if not min_value: min_value = tick_unit / tick_base diff --git a/src/lib_spark/spark/domain/tick_utils.cpp b/src/lib_spark/spark/domain/tick_utils.cpp index d46aa3e31..335b9f7ac 100644 --- a/src/lib_spark/spark/domain/tick_utils.cpp +++ b/src/lib_spark/spark/domain/tick_utils.cpp @@ -6,6 +6,12 @@ namespace bts::domain { template bool get_tick_factors(double tick_sz, T &tick_unit, T &tick_base) { + if (tick_sz > 1) { + // integer tick + tick_unit = tick_sz; + tick_base = 1; + return true; + } float qty_tick_denom = 1.0 / tick_sz; int qty_tick_denomi = static_cast(qty_tick_denom); if (qty_tick_denom != qty_tick_denomi) {